End the hold: the site is main's again - #62
Merged
Merged
Conversation
1.1.0 is on the store, so site/1.0.0 has done its job — deployed, branch and environment policy deleted, and the three paragraphs that described the hold go with them. A note saying the site is held, left standing after it is not, sends the next reader looking for a branch that no longer exists. Two things in those paragraphs were not about this episode, so they stay, shortened to a sentence each: that pages.yml can deploy a ref other than main at the cost of an entry in the environment's list, which is the escape hatch for exactly this situation and now has a worked example; and that a tag's site/ is the site as of the tag rather than as of the release, which is what made v1.0.0 the wrong thing to deploy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.1.0 is on the store, so the hold is over. Done in order, before this PR:
pages.yml --ref maindeployed — verified live:visionOS 26 以降in the requirements, Vision Pro and 🌳 back on the page,shots/vision-{en,ja}-1.pngandipad-en-4.pngserving 200, and privacy §6 still theresite/1.0.0deleted, remote and localgithub-pagesenvironment policy57912766deleted — the list is back tomainandgh-pagesSo the skill's three paragraphs describing the hold go too, as they themselves instructed. A note saying the site is held, left standing after it is not, sends the next reader looking for a branch that no longer exists.
Two things in them were not about this episode, and are kept as a sentence each:
pages.ymlcan deploy a ref that is not main — the escape hatch for exactly this shape, when the site must move while main is ahead of what shipped. The cost is an entry in the environment's ref list, and anything not in it fails in two seconds naming only the ref. The 1.1.0 window is now the worked example, including the part worth copying: carryingprivacy.htmlalone, so App Review could read why the app senses the room without the landing page advertising an unreleased version.site/is the site as of the tag, not as of the release.v1.0.0was cut before the app was on the store, so its page says "Coming soon" and points the badge at GitHub.Net: -32 lines, +11.